ia32 tested, arm almost finished.
http://codereview.chromium.org/487017/diff/8006/10006 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/487017/diff/8006/10006#newcode2734 src/x64/codegen-x64.cc:2734: frame_->Push(&receiver); On 2009/12/17 09:59:02, Lasse Reichstein wrote: > Could this be made faster by doing, effectively: > pop(tmp) > push(Operand(sp)) // aka Dup. > mov(Operand(sp,kPointerSize), tmp) > It seems like one less operation - but maybe not if the frame is virtual. The frame may well be virtual, in which case these may generate little or no runtime code. http://codereview.chromium.org/487017/diff/8006/10006#newcode2958 src/x64/codegen-x64.cc:2958: frame_->Push(&receiver); On 2009/12/17 09:59:02, Lasse Reichstein wrote: > Again a swap of the top two elements of the frame. > Perhaps give the frame a Swap operation. This may be a good idea. I'm not sure how much to optimize the resulting Swap operation, though. http://codereview.chromium.org/487017 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
