http://codereview.chromium.org/487017/diff/28009/20025
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/487017/diff/28009/20025#newcode3094
src/arm/codegen-arm.cc:3094: if (property->is_synthetic()) {
On 2010/01/22 09:09:46, Kevin Millikin wrote:
I think this is more straightforward. The only difference with
synthetic
properties is what we use for the receiver.
LoadAndSpill(property->obj());
LoadAndSpill(property->key());
EmitKeyedLoad(false);
frame_->Drop(); // Key.
// Put the function below the receiver.
if (property->is_synthetic()) {
// Use the global receiver.
frame_->Drop();
frame_->EmitPush(r0);
LoadGlobalReceiver(r0);
} else {
frame_->EmitPop(r1);
frame_->EmitPush(r0);
frame_->EmitPush(r1);
}
Done.
http://codereview.chromium.org/487017/diff/28009/20025#newcode4255
src/arm/codegen-arm.cc:4255: Comment cmnt(masm_, "[ Load from keyed
Property");
On 2010/01/22 09:09:46, Kevin Millikin wrote:
Not sure why you've got a six space indent here.
Done.
http://codereview.chromium.org/487017/diff/28009/20026
File src/arm/codegen-arm.h (right):
http://codereview.chromium.org/487017/diff/28009/20026#newcode51
src/arm/codegen-arm.h:51: // The reference representing a variable (a
bare identifier) usually has
On 2010/01/22 09:09:46, Kevin Millikin wrote:
This comment is still wrong. Just delete it and let the code speak
for itself.
Done. Changed on all platforms.
http://codereview.chromium.org/487017
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
