quick look over the cl, see comments. you got some buildbot failures. please
address first.
https://codereview.chromium.org/1133773002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1133773002/diff/20001/src/heap/heap.cc#newcode1789
src/heap/heap.cc:1789: } // namespace
Why did you add a namespace?
https://codereview.chromium.org/1133773002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1133773002/diff/20001/src/heap/mark-compact.cc#newcode3110
src/heap/mark-compact.cc:3110:
heap()->PromoteArrayBuffer(JSArrayBuffer::cast(target));
Please don't add any JS type specific functionality to this function.
You could iterate over the map after evacuation and see what got
promoted.
https://codereview.chromium.org/1133773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
