https://codereview.chromium.org/1133773002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1133773002/diff/20001/src/heap/heap.cc#newcode1789
src/heap/heap.cc:1789: } // namespace
On 2015/05/08 14:42:56, jochen (traveling) wrote:
On 2015/05/08 13:39:29, Hannes Payer wrote:
> Why did you add a namespace?
so the helpers above don't pollute the global namespace
I looked it up in the style guide. That's fine. However, we never do
that in our code base.
https://codereview.chromium.org/1133773002/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1133773002/diff/40001/src/heap/heap.cc#newcode2251
src/heap/heap.cc:2251: } else {
This logic could also be moved to the promotion queue. We should have
there a clean dispatch.
https://codereview.chromium.org/1133773002/diff/40001/src/heap/heap.cc#newcode2256
src/heap/heap.cc:2256:
heap->PromoteArrayBuffer(JSArrayBuffer::cast(target));
What about moving this logic into the promotion queue? That may be
cleaner.
https://codereview.chromium.org/1133773002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1133773002/diff/40001/src/heap/heap.h#newcode1513
src/heap/heap.h:1513:
Please add a bunch of comments about what these functions are doing.
https://codereview.chromium.org/1133773002/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1133773002/diff/40001/src/heap/mark-compact.cc#newcode3110
src/heap/mark-compact.cc:3110:
heap()->PromoteArrayBuffer(JSArrayBuffer::cast(target));
I think we should clean that up together with the specialized code in
migrate object. I like the idea of having a MigrationEpilog. Let's try
that and see how it looks.
https://codereview.chromium.org/1133773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
