https://codereview.chromium.org/1098663002/diff/60001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js#newcode116
src/promise.js:116: try { deferred.reject(exception); } catch (e) { }
Is this not already handled by the enclosing try/catch block?
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js#newcode120
src/promise.js:120: deferred.resolve(result);
This same branch is repeated a few times, maybe it's worth writing it so
that the duplication isn't needed? On the other hand, maybe it's more
readable this way.
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js#newcode140
src/promise.js:140: for (var i = 0; i < tasks.length; i += 3) {
This gets confusing, comments would be helpful
https://codereview.chromium.org/1098663002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
