https://codereview.chromium.org/1098663002/diff/60001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js#newcode110
src/promise.js:110: var then = result.then;
On 2015/05/11 13:53:15, arv wrote:
Isn't this extra Get observable?
In PromiseReactionJob[1], promiseCapability.[[Resolve]] a.k.a. promise
resolve function[2] is called. "then" is accessed in the function, so
accessing the property here is correct.
1:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-promisereactionjob
2:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-promise-resolve-functions
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js#newcode120
src/promise.js:120: deferred.resolve(result);
On 2015/05/11 03:02:16, caitp wrote:
This same branch is repeated a few times, maybe it's worth writing it
so that
the duplication isn't needed? On the other hand, maybe it's more
readable this
way.
Hmm, I don't have a good idea to unify them (partially because L120 and
L125 are in different functions). Do you have one?
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js#newcode140
src/promise.js:140: for (var i = 0; i < tasks.length; i += 3) {
On 2015/05/11 03:02:16, caitp wrote:
This gets confusing, comments would be helpful
Done.
https://codereview.chromium.org/1098663002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
