Thanks for the review Andreas.

All done, CQ'ing...


https://codereview.chromium.org/1115263004/diff/180001/test/mjsunit/strong/function-arity.js
File test/mjsunit/strong/function-arity.js (right):

https://codereview.chromium.org/1115263004/diff/180001/test/mjsunit/strong/function-arity.js#newcode5
test/mjsunit/strong/function-arity.js:5: // Flags: --strong-mode
--harmony-arrow-functions --harmony-reflect --harmony-spreadcalls
--allow-natives-syntax
On 2015/05/11 15:39:28, rossberg wrote:
Nit: line length

Done.

I fixed this but I guess I undid too much at one point...

https://codereview.chromium.org/1115263004/diff/180001/test/mjsunit/strong/function-arity.js#newcode269
test/mjsunit/strong/function-arity.js:269: function f(x, y) {}
On 2015/05/11 15:39:28, rossberg wrote:
It's also worth testing the case where the callee is weak (and does
not throw).

Done.

https://codereview.chromium.org/1115263004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to