Yes, looks good, ready for ports.
https://codereview.chromium.org/1115263004/diff/160001/test/mjsunit/strong/function-arity.js
File test/mjsunit/strong/function-arity.js (right):
https://codereview.chromium.org/1115263004/diff/160001/test/mjsunit/strong/function-arity.js#newcode5
test/mjsunit/strong/function-arity.js:5: // Flags: --strong-mode
--harmony-arrow-functions --harmony-reflect --harmony-spreadcalls
--allow-natives-syntax
Nit: line length (note that you can have multiple Flags: comments)
https://codereview.chromium.org/1115263004/diff/160001/test/mjsunit/strong/function-arity.js#newcode46
test/mjsunit/strong/function-arity.js:46: 'use strong';
Instead of having the directive outside the function, the more tricky
case is perhaps having it inside the function (consider lazy parsing).
So I'd move it into defs.
https://codereview.chromium.org/1115263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
