This looks great, I didn't realize how easy it was to add properties to a
non-extensible object.
I'm on vacation through Monday, so won't get back to this until next week.
The
only thing that I'm worried about is the question about the global below.
https://codereview.chromium.org/1142493002/diff/1/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/1142493002/diff/1/src/collection.js#newcode85
src/collection.js:85: if (IS_SPEC_OBJECT(key)) {
You might need a TODO here for handling proxies appropriately.
Also, will this get the wrong value for the JSGlobalProxy?
https://codereview.chromium.org/1142493002/diff/1/src/collection.js#newcode86
src/collection.js:86: var hash = key[hash_code_symbol];
We've been using a GET_PRIVATE() for this as a matter of style.
https://codereview.chromium.org/1142493002/diff/1/src/collection.js#newcode87
src/collection.js:87: if (hash == void 0) {
IS_UNDEFINED(hash)
https://codereview.chromium.org/1142493002/diff/1/src/collection.js#newcode89
src/collection.js:89: key[hash_code_symbol] = hash;
SET_PRIVATE()
https://codereview.chromium.org/1142493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
