https://codereview.chromium.org/1142493002/diff/1/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/1142493002/diff/1/src/collection.js#newcode85
src/collection.js:85: if (IS_SPEC_OBJECT(key)) {
On 2015/05/14 15:42:19, Erik Corry wrote:
On 2015/05/14 15:01:27, adamk wrote:
> You might need a TODO here for handling proxies appropriately.
>
> Also, will this get the wrong value for the JSGlobalProxy?
Probably. What's the deal with the JSGlobalProxy?
Due to split-object the global proxy points to the current global
object, which is a single object from the POV of the user. The global
proxy represents an iframe, whereas the global object represents a page
in the iframe. If the iframe navigates, the page changes, and hence the
link from the global proxy to the global object.
Access to the global proxy always relays the access to the global
object. So if you do window[hash_code_symbol], you'll get the hash-code
from the current page. That doesn't remain stable across navigation.
After navigation you won't be able to retrieve values associated with
the iframe anymore (unless there's a hash collision between the 2
pages).
https://codereview.chromium.org/1142493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
