I've reviewed the feedback vector stuff, and it looks good. Yes, it's
unfortunate that tests have to magically know which IC slot to query. Danno
proposed a runtime intrinsic that would record the ic slot you are
interested
in, then these magic numbers could be eliminated, something like:
int index_to_slot;
CompileRun("function foo(a) {"
" index_to_slot = %RecordNextSlot();"
" return a[i];");
// Now you can query the feedback vector at index_to_slot.
I should probably do this work before our tests accumulate more magic
numbers...
https://codereview.chromium.org/1135243004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
