for what it's worth, lgtm
https://codereview.chromium.org/1135243004/diff/100001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1135243004/diff/100001/src/preparser.h#newcode3386
src/preparser.h:3386: while (scope->is_eval_scope() ||
scope->is_arrow_scope()) {
Still makes sense to me to factor this out to a method on Scope, or to
add an optional arg to DeclarationScope or something.
https://codereview.chromium.org/1135243004/diff/100001/test/mjsunit/harmony/object-literals-super.js
File test/mjsunit/harmony/object-literals-super.js (right):
https://codereview.chromium.org/1135243004/diff/100001/test/mjsunit/harmony/object-literals-super.js#newcode145
test/mjsunit/harmony/object-literals-super.js:145: eval() {
This eval is not in the scope of the method? Strange; some day I'll
understand all of ES6...
https://codereview.chromium.org/1135243004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
