On 2015/05/15 13:55:56, arv wrote:
https://codereview.chromium.org/1141223002/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/1141223002/diff/1/src/messages.js#newcode144
src/messages.js:144: setter_rest_param: ["Setter function
argument
must not be a rest parameter"],
Can you use messages.h instead since Yang is in the process of removing
this
table from js.
https://codereview.chromium.org/1141223002/diff/1/test/message/rest-param-class-setter-strict.out
File test/message/rest-param-class-setter-strict.out (right):
https://codereview.chromium.org/1141223002/diff/1/test/message/rest-param-class-setter-strict.out#newcode3
test/message/rest-param-class-setter-strict.out:3: ^^^^^^^^^
The location here is a bit strange. Can it be improved to point at
`...args`
instead of `(...args)`?
it seemed harder to do that, but it would be nice :| I think the simplest
thing
was to just report this in ChecArityRestrictions, and it's maybe simpler to
just
reuse the existing setter arity error, the way SpiderMonkey does
https://codereview.chromium.org/1141223002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
