On 2015/05/15 14:01:28, caitp wrote:
https://codereview.chromium.org/1141223002/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/1141223002/diff/1/src/messages.js#newcode144
src/messages.js:144: setter_rest_param: ["Setter function
argument
must not be a rest parameter"],
On 2015/05/15 13:55:56, arv wrote:
> Can you use messages.h instead since Yang is in the process of removing
this
> table from js.
I'd like to, but it's not obvious how to make the parser's ReportMessage
infrastructure use the new message stuff, which I think is why most of
those
messages haven't been moved to that yet. The one SyntaxError which does
use
this
is part of a runtime function, which doesn't really apply to normal
parsing.
Maybe yangguo could shed some light on this, I'll add them as a reviewer
I think the only thing that can make this simpler is just getting rid of
the new
error, but I like that it's specific.
https://codereview.chromium.org/1141223002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
