https://codereview.chromium.org/1139663005/diff/1/src/array.js
File src/array.js (right):
https://codereview.chromium.org/1139663005/diff/1/src/array.js#newcode1254
src/array.js:1254: $innerArraySome = InnerArraySome;
Can you put all of these at the end?
https://codereview.chromium.org/1139663005/diff/1/src/array.js#newcode1645
src/array.js:1645:
should go here
https://codereview.chromium.org/1139663005/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1139663005/diff/1/src/harmony-typedarray.js#newcode132
src/harmony-typedarray.js:132: return ConstructTypedArrayLike(this,
array);
This one can be preallocated instead of using a temporary array. Add a
TODO?
https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typedarray-iteration.js
File test/mjsunit/harmony/typedarray-iteration.js (right):
https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typedarray-iteration.js#newcode42
test/mjsunit/harmony/typedarray-iteration.js:42: a = new
constructor([1,42,3,42,4]);
space after comma
https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typedarray-iteration.js#newcode70
test/mjsunit/harmony/typedarray-iteration.js:70: }, "");
stick to either " or '
https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typedarray-iteration.js#newcode88
test/mjsunit/harmony/typedarray-iteration.js:88: //
%TypedArray%.prototype.map
Other tests tend to use the following format:
(function TestNameOfTest() {
...
})();
Then the stack trace will tell you which part you was failing.
Then you can also remove the comment since the name should explain what
is being tested.
https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typedarray-iteration.js#newcode132
test/mjsunit/harmony/typedarray-iteration.js:132:
map is a bit special since the return value might no longer fit (or be a
number) in the typed array. Can you add a few tests for that?
https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typedarray-reduce.js
File test/mjsunit/harmony/typedarray-reduce.js (right):
https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typedarray-reduce.js#newcode8
test/mjsunit/harmony/typedarray-reduce.js:8: * @fileoverview Test
%TypedArray%.prototype.reduce and .reduceRight
no jsdoc needed
https://codereview.chromium.org/1139663005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
