On 2015/05/19 13:44:06, arv wrote:
LGTM
Please add a bug/todo for using InternalArray.
https://codereview.chromium.org/1139663005/diff/20001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/1139663005/diff/20001/src/array.js#newcode1158
src/array.js:1158: function InnerArrayFilter(f, receiver, array, length) {
I think we have an issue with typed arrays since we are creating a new
Array
which can have setters.
Object.defineProperty(Array.prototype, 1, {set: function(v) {
alert(v);
});
For the typed arrays we can use InternalArray (where the spec asks for a
List).
Filed v8:4128
https://codereview.chromium.org/1139663005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
