https://codereview.chromium.org/1141393002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1141393002/diff/1/src/heap/gc-idle-time-handler.cc#newcode297
src/heap/gc-idle-time-handler.cc:297: return
GCIdleTimeAction::Nothing();
On 2015/05/19 09:50:32, Hannes Payer wrote:
What about this one and the one above? Also nothing or done?
Just this one I think (the one above should probably still be Nothing
since it only happens if we get a negative idle time).
https://codereview.chromium.org/1141393002/diff/1/src/heap/gc-idle-time-handler.cc#newcode348
src/heap/gc-idle-time-handler.cc:348:
kLongIdleNotificationsBeforeMutatorIsIdle / 2;
I don't understand this - what is
kLongIdleNotificationsBeforeMutatorIsIdle representing and why do we
divide it by two here?
https://codereview.chromium.org/1141393002/diff/1/test/unittests/heap/gc-idle-time-handler-unittest.cc
File test/unittests/heap/gc-idle-time-handler-unittest.cc (right):
https://codereview.chromium.org/1141393002/diff/1/test/unittests/heap/gc-idle-time-handler-unittest.cc#newcode661
test/unittests/heap/gc-idle-time-handler-unittest.cc:661:
Can we add back the two tests for NothingOrDone which were removed in
the previous CL too please.
https://codereview.chromium.org/1141393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
