On 2015/05/19 14:36:34, rmcilroy wrote:
lgtm, thanks.
https://codereview.chromium.org/1141393002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1141393002/diff/1/src/heap/gc-idle-time-handler.cc#newcode348
src/heap/gc-idle-time-handler.cc:348:
kLongIdleNotificationsBeforeMutatorIsIdle
/ 2;
On 2015/05/19 11:21:52, ulan wrote:
> On 2015/05/19 10:26:57, rmcilroy wrote:
> > I don't understand this - what is
kLongIdleNotificationsBeforeMutatorIsIdle
> > representing and why do we divide it by two here?
>
> This was trying to encode two different counters: one for foreground
tab and
one
> for background tab. For background tab we want to go faster in reduce
memory
> mode. I made it explicit in the new patch set.
This is clearer, thanks.
https://codereview.chromium.org/1141393002/diff/60001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1141393002/diff/60001/src/heap/gc-idle-time-handler.cc#newcode351
src/heap/gc-idle-time-handler.cc:351: background_idle_notifications_++;
do we want this instead:
if (idle_time_in_ms >= kMinBackgroundIdleTime) {
background_idle_notifications_++;
} else if (idle_time_in_ms >= kMinLongIdleTime) {
long_idle_notifications_++;
}
This would ensure we don't overcount long_idle_notifications.
https://codereview.chromium.org/1141393002/diff/60001/src/heap/gc-idle-time-handler.cc#newcode376
src/heap/gc-idle-time-handler.cc:376: int gcs) {
nit - gcs -> mutator_gcs
Lgtm
https://codereview.chromium.org/1141393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
