On 2015/05/15 16:13:34, Jakob wrote:
I don't remember the specifics; this is the CL that introduced that line:
https://codereview.chromium.org/70233010
This just happens to be the boundary between intptr_t and int64_t worlds.
On
32-bit platforms, we need to guard against overflow there. Why do you
want to
remove the check?
I want to remove the check because it's totally broken for 64 bit platforms
like
node.js that routinely raise the heap size.
This isn't something I want to spend a lot of time on, since we don't have a
repro of a problem in Chrome, but as a compromise we could get rid of this
line
on 64 bit where it is obviously completely broken. New patch set uploaded.
https://codereview.chromium.org/1133243006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
