Suggestion below.
Sven, do you have an opinion?
https://codereview.chromium.org/1133243006/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1133243006/diff/20001/src/heap/heap.h#newcode1084
src/heap/heap.h:1084: if (sizeof(int) < sizeof(int64_t) && total >
kMaxInt) {
Isn't "sizeof(int) < sizeof(int64_t)" true on all platforms? How about
we change the original line to:
if (total > std::numeric_limits<intptr_t>::max()) {
return std::numeric_limits<intptr_t>::max();
}
https://codereview.chromium.org/1133243006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
