On 2015/05/18 22:04:01, paul.l... wrote:
mips and mips64 ports LGTM. kPointerSize can NOT be kInt32Size on mips64.
(I
think that is used only to support the x32 ABI variant on x64.)
Thanks.
I don't think that arm64 supports that either. On arm64, the Ldrsh() looks
suspicious to me, as that is doing a 16-bit load. Even on x64, when the
pointer
size is 32 bits, these fields are still 32-bits wide. But of course I'd
defer
to
Rodolph or any other arm person on this.
I'll add DCHECKS to enforce this.
https://codereview.chromium.org/1133933003/diff/100001/src/mips64/builtins-mips64.cc
File src/mips64/builtins-mips64.cc (right):
https://codereview.chromium.org/1133933003/diff/100001/src/mips64/builtins-mips64.cc#newcode1764
src/mips64/builtins-mips64.cc:1764: __ srl(a5, a5, 1);
A couple nits that I think are completely unimportant for this usage: lw()
will
sign extend (lwu() will zero-extend). If you expect negative numbers then
your
shift should be sra(). Since this is a parameter count, it won't be
negative,
and it won't be close to 2^31 so I don't think either comment applies
here.
https://codereview.chromium.org/1133933003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
