This is awesome feedback. Makes me wish all assembly was reviewed by experts
like you.
https://codereview.chromium.org/1133933003/diff/100001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
https://codereview.chromium.org/1133933003/diff/100001/src/arm/builtins-arm.cc#newcode1737
src/arm/builtins-arm.cc:1737: __ cmp(r0, r4);
On 2015/05/19 14:37:05, Rodolph Perfetta wrote:
The two instructions above can be merged:
__ cmp(r0, Operand::SmiUntag(r4));
Done.
https://codereview.chromium.org/1133933003/diff/100001/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):
https://codereview.chromium.org/1133933003/diff/100001/src/arm64/builtins-arm64.cc#newcode1765
src/arm64/builtins-arm64.cc:1765: __ bind(&no_strong_error);
On 2015/05/19 14:37:06, Rodolph Perfetta wrote:
No part of your patch but we should use the macro assembler so
Bind(...)
I added that bind so I'm happy to change it to Bind to get the
assertion.
https://codereview.chromium.org/1133933003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
