Dmitry. I wanted to unblock you from spread patterns but this still needs a
little bit more work.
The approach is similar to computed property names in object literals. We
let
the array elements up to the first spread element be created like before and
after that we append elements to the array.
One alternative design would be to desugar it in the parser but the problem
with
that is that we would have to go back and change the AST when we finally
know if
the array literal is going to end up as an array literal and not as an array
pattern.
It is not clear to me why turbofan is trying to optimize this even when I
call
DisableOptimization in ast-numbering.cc.
TODO:
- Classifier
- More tests
- Ports
- TF (in a follow up CL)
- Crankshaft?
https://codereview.chromium.org/1125183008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
