Neat! lgtm % TF (looks good to me too but I am no expert)
https://codereview.chromium.org/1125183008/diff/100001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/1125183008/diff/100001/src/ia32/full-codegen-ia32.cc#newcode1863
src/ia32/full-codegen-ia32.cc:1863: __ add(esp,
Immediate(kPointerSize)); // literal index
__ Drop(1) should work too AFAIR
https://codereview.chromium.org/1125183008/diff/100001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1125183008/diff/100001/src/runtime.js#newcode950
src/runtime.js:950: function ConcatIterableToArray(target, iterable) {
Duplicate function
https://codereview.chromium.org/1125183008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
