lgtm ~ comments:
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json
File test/simdjs/SimdJs.json (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode3
test/simdjs/SimdJs.json:3: "run_count": 5,
Is 5 ok? What's the total time of running this?
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode27
test/simdjs/SimdJs.json:27: "flags": ["--harmony-object",
"test/simdjs/harness-adapt.js"],
Should this be benchmark-adapt?
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode28
test/simdjs/SimdJs.json:28: "path": ["../../"],
Can the workdir not be "." and all paths be relative to it? Or are there
hardcoded loads in the runner relative to the v8 base dir?
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode32
test/simdjs/SimdJs.json:32: "main": "test/simdjs/harness-finish.js",
It will make a new call to d8 for each "main" file. I guess that's what
you want. The benchmarks will appear in a hierarchy like this:
SIMDJS/kernel-template/SIMD
SIMDJS/kernel-template/Non-SIMD
etc
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode45
test/simdjs/SimdJs.json:45: "flags":
["test/simdjs/data/src/benchmarks/averageFloat32x4.js"],
Does this work as expected? Flags are passed to d8 before the main file
I think. So you'd have:
d8 --harmony-object test/simdjs/harness-adapt.js
test/simdjs/data/src/benchmarks/averageFloat32x4.js
test/simdjs/harness-finish.js
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/benchmarks-adapt.js
File test/simdjs/benchmarks-adapt.js (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/benchmarks-adapt.js#newcode6
test/simdjs/benchmarks-adapt.js:6:
This is not used yet. See comment in other file.
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/generate.py
File test/simdjs/generate.py (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/generate.py#newcode12
test/simdjs/generate.py:12:
I'm rubber-stamping this. Instead of a string, a python dict that's
json.dumped could have been more readable. But I don't care...
https://codereview.chromium.org/1146073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
