PTAL
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json
File test/simdjs/SimdJs.json (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode3
test/simdjs/SimdJs.json:3: "run_count": 5,
On 2015/05/20 10:33:16, Michael Achenbach wrote:
Is 5 ok? What's the total time of running this?
It seems to be ok (I'm assuming this is because the 4 variants run for
testings aren't done here and the default for the slow test is
reasonably fast).
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode27
test/simdjs/SimdJs.json:27: "flags": ["--harmony-object",
"test/simdjs/harness-adapt.js"],
On 2015/05/20 10:33:17, Michael Achenbach wrote:
Should this be benchmark-adapt?
Actually this is right, but that file was from an attempt to approach
this differently (invoke run.js once and collect everything), that
proved more verbose.
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode28
test/simdjs/SimdJs.json:28: "path": ["../../"],
On 2015/05/20 10:33:16, Michael Achenbach wrote:
Can the workdir not be "." and all paths be relative to it? Or are
there
hardcoded loads in the runner relative to the v8 base dir?
This lets me share the harness-adapt/finish with the testing version of
this.
I could make another one for this case that's rooted here, but would
need slightly different versions of those two.
Which do you prefer
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode32
test/simdjs/SimdJs.json:32: "main": "test/simdjs/harness-finish.js",
On 2015/05/20 10:33:17, Michael Achenbach wrote:
It will make a new call to d8 for each "main" file. I guess that's
what you
want. The benchmarks will appear in a hierarchy like this:
SIMDJS/kernel-template/SIMD
SIMDJS/kernel-template/Non-SIMD
etc
I assume this is preferrable, as then then run_perf knows about each?
I had tried it the other way round (run run.js once), but then it seemed
more verbose and then run_perf doesn't know about all the sub -tests.
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/SimdJs.json#newcode45
test/simdjs/SimdJs.json:45: "flags":
["test/simdjs/data/src/benchmarks/averageFloat32x4.js"],
On 2015/05/20 10:33:17, Michael Achenbach wrote:
Does this work as expected? Flags are passed to d8 before the main
file I think.
So you'd have:
d8 --harmony-object test/simdjs/harness-adapt.js
test/simdjs/data/src/benchmarks/averageFloat32x4.js
test/simdjs/harness-finish.js
Yes this is the intended set of args.
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/benchmarks-adapt.js
File test/simdjs/benchmarks-adapt.js (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/benchmarks-adapt.js#newcode6
test/simdjs/benchmarks-adapt.js:6:
On 2015/05/20 10:33:17, Michael Achenbach wrote:
This is not used yet. See comment in other file.
Dropped, leftover from the other approach.
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/generate.py
File test/simdjs/generate.py (right):
https://codereview.chromium.org/1146073002/diff/1/test/simdjs/generate.py#newcode12
test/simdjs/generate.py:12:
On 2015/05/20 10:33:17, Michael Achenbach wrote:
I'm rubber-stamping this. Instead of a string, a python dict that's
json.dumped
could have been more readable. But I don't care...
Yeah I almost did that.
Switching.
https://codereview.chromium.org/1146073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
