lgtm. Some nitpicks, though.
https://codereview.chromium.org/1149633003/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/1149633003/diff/1/Makefile#newcode152
Makefile:152: # imminent_deprecation_warnings=on
spelling?
I take it the comment is meant to document the option, in which case it
should be spelled the same as the actual option. (That is, with the same
number of underscores.)
(Also, same issue above on deprecation_warnings, but not strictly
relates to your code.)
https://codereview.chromium.org/1149633003/diff/1/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/1149633003/diff/1/include/v8config.h#newcode330
include/v8config.h:330: // a macro to make it easier to see what will be
deprecated.
"a macro" => "a plethora of macros".
Or maybe, put V8_DEPRECATE_SOON into the lead-in comment, since it's now
pretty hard to see what is actually being defined here. I at least had
to read a good bit to be sure that this block will always define
V8_DEPRECATE_SOON (and nothing else). Same above.
https://codereview.chromium.org/1149633003/diff/1/include/v8config.h#newcode334
include/v8config.h:334: declarator __attribute__((deprecated(message)))
Style nitpick: Indent is weird. It's 4 chars above, 2 chars here. Not
sure what we even want here. There's no indent at all in the block
above.
https://codereview.chromium.org/1149633003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
