lgtm
A bit more nitpickery, though.
https://codereview.chromium.org/1149633003/diff/1/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/1149633003/diff/1/include/v8config.h#newcode334
include/v8config.h:334: declarator __attribute__((deprecated(message)))
On 2015/05/21 09:30:31, jochen wrote:
On 2015/05/21 at 09:17:09, vogelheim wrote:
> Style nitpick: Indent is weird. It's 4 chars above, 2 chars here.
Not sure
what we even want here. There's no indent at all in the block above.
it's what clang-format does :-/
the block above is hand-written, I can clang-format it as well...
It's fine, then. All glory to clang-format!
https://codereview.chromium.org/1149633003/diff/20001/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/1149633003/diff/20001/include/v8config.h#newcode316
include/v8config.h:316: // A macro (V8_DEPRECASTED) to mark classes or
functions as deprecated.
V8_DEPRECASTED => V8_DEPRECATED
https://codereview.chromium.org/1149633003/diff/20001/include/v8config.h#newcode330
include/v8config.h:330: // a macro (V8_DEPRECATE_SOON) to make it easier
to see what will be deprecated.
Super nitpick: Capital A in "A macro ..."
https://codereview.chromium.org/1149633003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
