On 2015/05/22 10:56:15, Hannes Payer wrote:
This cl seems to be in a strange merge state with an older version of
Issue
1152513002: Generalize alignment in heap GC functions. Could you please
resolve
that.
https://codereview.chromium.org/1150593003/diff/80001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/1150593003/diff/80001/src/globals.h#newcode441
src/globals.h:441: enum AllocationAlignment { kWordAligned,
kDoubleAligned,
kDoubleValueAligned };
I called it kDoubleUnaligned because it is general. kDoubleValueAligned
just
corresponds to the HeapNumber case, not necessarily to any other object
type,
for which the value would have to be aligned differently.
Sorry, I should have said it's not quite ready for a real review. I'll
change
back to your name then. I'll be adding a kSimd128Unaligned enum value in an
upcoming CL.
https://codereview.chromium.org/1150593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
