Cool! I left a few comments about the tests.
https://codereview.chromium.org/1150593003/diff/260001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1150593003/diff/260001/test/cctest/test-heap.cc#newcode1841
test/cctest/test-heap.cc:1841: // cause exactly one filler object to be
created.
Let's also check if the filler is there.
https://codereview.chromium.org/1150593003/diff/260001/test/cctest/test-heap.cc#newcode1849
test/cctest/test-heap.cc:1849: CHECK(IsAddressAligned(obj1->address(),
kDoubleAlignment, kPointerSize));
This address should not be double aligned.
https://codereview.chromium.org/1150593003/diff/260001/test/cctest/test-heap.cc#newcode1876
test/cctest/test-heap.cc:1876: HeapObject* obj1 =
AllocateUnalignedAndFill(
Here, I would rather test the free-list allocation and check if the
object is a the right alignment and the fillers are e.g. before and
after the object.
https://codereview.chromium.org/1150593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
