That looks a lot simpler. Looking good, just some minor comments.
https://codereview.chromium.org/1130393003/diff/140001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1130393003/diff/140001/src/code-stubs.h#newcode2346
src/code-stubs.h:2346: static bool
has_convert_hole_to_undefined(uint32_t minor_key) {
has_converted_hole_to_undefined or converts_hole_to_undefined or so?
https://codereview.chromium.org/1130393003/diff/140001/src/ic/ic-compiler.h
File src/ic/ic-compiler.h (right):
https://codereview.chromium.org/1130393003/diff/140001/src/ic/ic-compiler.h#newcode34
src/ic/ic-compiler.h:34: // if the receiver map is the initial array map
for FAST_HOLEY_SMI_ELEMENTS,
If
https://codereview.chromium.org/1130393003/diff/140001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1130393003/diff/140001/src/ic/ic.cc#newcode1262
src/ic/ic.cc:1262:
isolate->IsFastArrayConstructorPrototypeChainIntact()) {
Can you put these 2 calls into a helper
CanTreatHoleAsUndefined? That way it's clear that they belong together;
and easy to support more cases in the future.
https://codereview.chromium.org/1130393003/diff/140001/src/ic/ic.cc#newcode1269
src/ic/ic.cc:1269: if (fixed_array->get(int_key) ==
*isolate->factory()->the_hole_value()) {
isolate->heap()->the_hole_value() is the unhandlified version.
You can also just do get(int_key)->IsTheHole(); or even better:
fixed_array->is_the_hole(int_key).
https://codereview.chromium.org/1130393003/diff/140001/src/ic/ic.cc#newcode1293
src/ic/ic.cc:1293: saw_the_hole);
What about passing the HoleySmiKeyedLoadResult in here, rather than an
anonymous boolean?
https://codereview.chromium.org/1130393003/diff/140001/src/ic/ic.cc#newcode1346
src/ic/ic.cc:1346: saw_the_hole);
Same here
https://codereview.chromium.org/1130393003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
