https://codereview.chromium.org/1159433003/diff/140001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1159433003/diff/140001/src/elements.cc#newcode1643
src/elements.cc:1643: return index;
I think we should not break this invariant:
DCHECK_EQ(key, GetKeyForIndexImpl(parameters,
GetIndexForKeyImpl(parameters, key));
Currently we don't convert keys to indices and back, but if we ever
do...
https://codereview.chromium.org/1159433003/diff/140001/src/elements.h
File src/elements.h (right):
https://codereview.chromium.org/1159433003/diff/140001/src/elements.h#newcode82
src/elements.h:82: inline MaybeHandle<AccessorPair>
GetAccessorPair(Handle<JSObject> holder,
nit: MUST_USE_RESULT ?
https://codereview.chromium.org/1159433003/diff/140001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1159433003/diff/140001/src/objects-inl.h#newcode6525
src/objects-inl.h:6525: CHECK(Object::cast(READ_FIELD(this,
kLengthOffset))->ToArrayIndex(&index));
ToArrayLength()?
https://codereview.chromium.org/1159433003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
