Addressed comments. I cannot support GetKeyForIndex in sloppy arguments
objects
though. Marking it as unreachable instead.
https://codereview.chromium.org/1159433003/diff/140001/src/elements.h
File src/elements.h (right):
https://codereview.chromium.org/1159433003/diff/140001/src/elements.h#newcode82
src/elements.h:82: inline MaybeHandle<AccessorPair>
GetAccessorPair(Handle<JSObject> holder,
On 2015/05/26 17:11:56, Igor Sheludko wrote:
nit: MUST_USE_RESULT ?
The MaybeHandle here means that there might not be an accessor, not that
an exception might be thrown. Hence MUST_USE_RESULT isn't necessary.
This method will go away soon anyway.
https://codereview.chromium.org/1159433003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
