Cool!
https://codereview.chromium.org/1038313003/diff/180001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1038313003/diff/180001/src/flag-definitions.h#newcode614
src/flag-definitions.h:614: "the goal maximum percentage of free space
in committed memory")
goal -> target
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode682
src/heap/mark-compact.cc:682:
->CurrentNewSpaceAllocationThroughputInBytesPerMillisecond());
That should be now overall allocation throughput.
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode696
src/heap/mark-compact.cc:696: const int kTargetFragmentationPercent =
50;
Don't you wanna use the FLAG_target_fragmentation here?
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode740
src/heap/mark-compact.cc:740: }
This piece needs a comment.
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode742
src/heap/mark-compact.cc:742: int estimated_released_pages =
candidate_count - estimated_new_pages;
estimated_released_pages can be negative. That is a bit strange.
https://codereview.chromium.org/1038313003/diff/180001/src/heap/spaces.h
File src/heap/spaces.h (right):
https://codereview.chromium.org/1038313003/diff/180001/src/heap/spaces.h#newcode681
src/heap/spaces.h:681: int available_in_small_free_list_;
Why int? What about size_t?
https://codereview.chromium.org/1038313003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
