Thanks. I uploaded new patch.
https://codereview.chromium.org/1038313003/diff/180001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1038313003/diff/180001/src/flag-definitions.h#newcode614
src/flag-definitions.h:614: "the goal maximum percentage of free space
in committed memory")
On 2015/05/27 08:49:30, Hannes Payer wrote:
goal -> target
Removed the flags.
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode682
src/heap/mark-compact.cc:682:
->CurrentNewSpaceAllocationThroughputInBytesPerMillisecond());
On 2015/05/27 08:49:30, Hannes Payer wrote:
That should be now overall allocation throughput.
Done.
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode696
src/heap/mark-compact.cc:696: const int kTargetFragmentationPercent =
50;
On 2015/05/27 08:49:30, Hannes Payer wrote:
Don't you wanna use the FLAG_target_fragmentation here?
I removed the flags to be consistent with "*ForReduceMemory" constants.
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode740
src/heap/mark-compact.cc:740: }
On 2015/05/27 08:49:30, Hannes Payer wrote:
This piece needs a comment.
Done.
https://codereview.chromium.org/1038313003/diff/180001/src/heap/mark-compact.cc#newcode742
src/heap/mark-compact.cc:742: int estimated_released_pages =
candidate_count - estimated_new_pages;
On 2015/05/27 08:49:30, Hannes Payer wrote:
estimated_released_pages can be negative. That is a bit strange.
I think estimated_new_page <= candidate_count always holds. Added DCHECK
https://codereview.chromium.org/1038313003/diff/180001/src/heap/spaces.h
File src/heap/spaces.h (right):
https://codereview.chromium.org/1038313003/diff/180001/src/heap/spaces.h#newcode681
src/heap/spaces.h:681: int available_in_small_free_list_;
On 2015/05/27 08:49:30, Hannes Payer wrote:
Why int? What about size_t?
All free list counters in other places are signed. I changed it from
intptr_t to int because we don't need 64-bits to count free bytes in a
page.
https://codereview.chromium.org/1038313003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
