lgtm % (nit + naming)
https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc#newcode239
src/ast.cc:239: DCHECK_NOT_NULL(expr->AsFunctionLiteral());
This DCHECK seems a little over-anxious, the above if statement already
checked this.
https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc#newcode4106
src/parser.cc:4106: if (entry.needs_home_object())
scope_->RecordSuperPropertyUsage();
Maybe rename RecordSuperPropertyUsage() to something about HomeObject?
I'll admit "RecordNeedsHomeObject" doesn't sound great, though.
https://codereview.chromium.org/1164073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
