https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc#newcode4106
src/parser.cc:4106: if (entry.needs_home_object())
scope_->RecordSuperPropertyUsage();
On 2015/06/04 20:15:57, arv wrote:
On 2015/06/04 20:02:33, adamk wrote:
> Maybe rename RecordSuperPropertyUsage() to something about
HomeObject? I'll
> admit "RecordNeedsHomeObject" doesn't sound great, though.
Yeah. This could be improved.
The Scope keeps track of both super.property and eval but the logging
does not
keep 2 flags. So, when we recreate the Scope from the log we lost the
calls_eval
flag (it gets set again in the eager parsing)
I changed it to use 2 fields in the logger instead. It is not required
but it is cleaner and straightforward.
https://codereview.chromium.org/1164073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
