I'm a bit worried about this affecting parse performance, due to the
increased
shuffling around of classifier data. But maybe it's not that bad.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode626
src/preparser.h:626: inline void
AppendAssignmentTarget(AssignmentTargetType value) {
On 2015/06/04 20:08:03, arv wrote:
s/value/type/
Done.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode2615
src/preparser.h:2615: ExpressionClassifier binding_classifier;
On 2015/06/04 20:08:03, arv wrote:
rename this?
Done.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3072
src/preparser.h:3072: ParserBase<Traits>::ParseAssignmentExpression(bool
accept_IN, bool is_rhs,
On 2015/06/04 20:08:03, arv wrote:
TODO: Maybe add enums for this and accept_IN?
Done.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3087
src/preparser.h:3087: bool maybeAssignmentPattern =
On 2015/06/04 20:08:03, arv wrote:
maybe_assignment_pattern
Done.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3088
src/preparser.h:3088: allow_harmony_destructuring() && !is_rhs &&
On 2015/06/04 20:08:04, arv wrote:
maybe rename is_rhs to is_lhs?
renamed to `pattern_lhs` in a previous patch
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h#newcode3144
src/preparser.h:3144: bool validDestructuringAssignmentTarget =
On 2015/06/04 20:08:04, arv wrote:
s/validDestructuringAssignmentTarget/valid_destructuring_assignment_target/
Done.
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc#newcode6545
test/cctest/test-parsing.cc:6545: {"var x, y, z; (", " = {});"},
On 2015/06/04 20:08:04, arv wrote:
Do you want to do for-in and for-of too?
Done.
https://codereview.chromium.org/1168643005/diff/20001/test/cctest/test-parsing.cc#newcode6583
test/cctest/test-parsing.cc:6583: NULL};
On 2015/06/04 20:08:04, arv wrote:
Needs more LHS expressions.
this.x
super.x
o['x']
f().prop
(lhsExpr)
Can be done in a follow up if you want.
I've added a bunch of these
https://codereview.chromium.org/1168643005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
