Very sorry for a looong delay :(
Looks good to me modulo other people's comments and a test comment below.
https://codereview.chromium.org/1168643005/diff/300001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1168643005/diff/300001/test/cctest/test-parsing.cc#newcode6565
test/cctest/test-parsing.cc:6565: "{ x : y }",
Add more tests of the form:
{ x : y.z } = ...
{ x : foo().x ) = ...
and so on (where the binding location is not a valid binding)
You have some of these, but not all. Consider the tests of "pattern
context":
{ x : E }
{ x : { y : E }}
[E]
[a, b, E]
....
where E is various valid assignment targets (x.y, foo(y), x[i] etc.)
https://codereview.chromium.org/1168643005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
