Lgtm, with comments.
http://codereview.chromium.org/546032/diff/1/7 File src/array.js (right): http://codereview.chromium.org/546032/diff/1/7#newcode986 src/array.js:986: if(IS_UNDEFINED(element)) { Space after if. http://codereview.chromium.org/546032/diff/1/4 File src/runtime.cc (right): http://codereview.chromium.org/546032/diff/1/4#newcode569 src/runtime.cc:569: if (obj->GetPrototype()->IsJSObject() && Here and below we do obj->GetPrototype() three times. Consider fetching it into a local variable just once. http://codereview.chromium.org/546032/diff/1/8 File test/mjsunit/get-own-property-descriptor.js (right): http://codereview.chromium.org/546032/diff/1/8#newcode43 test/mjsunit/get-own-property-descriptor.js:43: assertTrue(descIsAccessor.configurable); Consider adding checks that descIsAccessor.{get,set} return the expected values. http://codereview.chromium.org/546032
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
