http://codereview.chromium.org/546032/diff/1/7
File src/array.js (right):
http://codereview.chromium.org/546032/diff/1/7#newcode986
src/array.js:986: if(IS_UNDEFINED(element)) {
On 2010/01/13 11:30:45, Christian Plesner Hansen wrote:
Space after if.
Done.
http://codereview.chromium.org/546032/diff/1/4
File src/runtime.cc (right):
http://codereview.chromium.org/546032/diff/1/4#newcode569
src/runtime.cc:569: if (obj->GetPrototype()->IsJSObject() &&
On 2010/01/13 11:30:45, Christian Plesner Hansen wrote:
Here and below we do obj->GetPrototype() three times. Consider
fetching it into
a local variable just once.
Done.
http://codereview.chromium.org/546032/diff/1/8
File test/mjsunit/get-own-property-descriptor.js (right):
http://codereview.chromium.org/546032/diff/1/8#newcode43
test/mjsunit/get-own-property-descriptor.js:43:
assertTrue(descIsAccessor.configurable);
On 2010/01/13 11:30:45, Christian Plesner Hansen wrote:
Consider adding checks that descIsAccessor.{get,set} return the
expected values.
Done.
http://codereview.chromium.org/546032
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
