Almost good, but I do not like the massive code duplication in the platform
ports.
https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode172
src/deoptimizer.h:172: const_reference operator[](size_t index) const {
return values_[index]; }
As discussed offline, we should not expose the values_ array because it
is a flattened array of values (i.e., fields of captured objects appear
in the array), so indexing does not do what you think it should do.
https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode174
src/deoptimizer.h:174: size_t size() const { return values_.size(); }
Remove this. You should use the GetValueCount method.
https://codereview.chromium.org/1169103004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
