Yeah I don't like the duplication either, but that was the minimal amount of
time and energy required to keep Crankshaft alive. Everything else requires
even
more time and energy for no use...
https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode172
src/deoptimizer.h:172: const_reference operator[](size_t index) const {
return values_[index]; }
On 2015/06/10 11:15:04, jarin wrote:
As discussed offline, we should not expose the values_ array because
it is a
flattened array of values (i.e., fields of captured objects appear in
the
array), so indexing does not do what you think it should do.
Done.
https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode174
src/deoptimizer.h:174: size_t size() const { return values_.size(); }
On 2015/06/10 11:15:04, jarin wrote:
Remove this. You should use the GetValueCount method.
Done.
https://codereview.chromium.org/1169103004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
