Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [strong] Refactor ObjectStrength into a replacement for strong boolean
args
port dd8544495109804c632bfbcefc3c5c701e0a8c43 (r28839)
original commit message:
Boolean "is_strong" parameters have begun to proliferate across areas
where
strong mode semantics are different. This CL repurposes the existing
ObjectStrength enum as a replacement for them.
BUG=
Please review this at https://codereview.chromium.org/1173973002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/x87/lithium-x87.h
Index: src/x87/lithium-x87.h
diff --git a/src/x87/lithium-x87.h b/src/x87/lithium-x87.h
index
cc4620d99e6251ed8b024399a67003d019006118..2e95cab4ab2134bf25412dd3e02beaf3a58269c6
100644
--- a/src/x87/lithium-x87.h
+++ b/src/x87/lithium-x87.h
@@ -1182,7 +1182,7 @@ class LCmpT final : public LTemplateInstruction<1, 3,
0> {
DECLARE_CONCRETE_INSTRUCTION(CmpT, "cmp-t")
DECLARE_HYDROGEN_ACCESSOR(CompareGeneric)
- LanguageMode language_mode() { return hydrogen()->language_mode(); }
+ Strength strength() { return hydrogen()->strength(); }
LOperand* context() { return inputs_[0]; }
Token::Value op() const { return hydrogen()->token(); }
@@ -1549,7 +1549,7 @@ class LArithmeticT final : public
LTemplateInstruction<1, 3, 0> {
DECLARE_HYDROGEN_ACCESSOR(BinaryOperation)
- LanguageMode language_mode() { return hydrogen()->language_mode(); }
+ Strength strength() { return hydrogen()->strength(); }
private:
Token::Value op_;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.