https://codereview.chromium.org/1180473003/diff/1/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/1180473003/diff/1/tools/run-tests.py#newcode386
tools/run-tests.py:386: if options.random_seed_stress_count <= 1:
Shouldn't this condition include a check that options.random_seed == 0?
Otherwise it's a bit surprising that any explicitly specified random
seed will silently be overwritten unless the random seed stress count is
1.
https://codereview.chromium.org/1180473003/diff/1/tools/run-tests.py#newcode565
tools/run-tests.py:565: options.random_seed,
In case of --random-seed=1 --random-seed-stress-count=2, this will lead
to duplicate --random-seed flags on the final test command line, right?
One coming from the test case (cf. CopyAddingFlags below), and one
coming from the context.
https://codereview.chromium.org/1180473003/diff/1/tools/run-tests.py#newcode620
tools/run-tests.py:620: yield ["--random-seed=%s" % str(seed)]
nit: explicit str() is not necessary when using %s (arguably %d would be
more appropriate, and still wouldn't need manual conversion)
https://codereview.chromium.org/1180473003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
