Comment #4 on issue 4178 by [email protected]: support
double-unaligned (and maybe simd128-unaligned) for snapshot
https://code.google.com/p/v8/issues/detail?id=4178#c4
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/33ae0e6762011e80172b84054a0a90e3b0822772
commit 33ae0e6762011e80172b84054a0a90e3b0822772
Author: machenbach <[email protected]>
Date: Tue Jun 16 10:18:33 2015
Revert of Serializer: support all alignment kinds. (patchset #3 id:40001 of
https://codereview.chromium.org/1179873003/)
Reason for revert:
[Sheriff] Breaks arm debug compile:
http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/4308
Original issue's description:
Serializer: support all alignment kinds.
We use an alignment prefix for unusual alignment kinds (not kWordAligned).
This will cause new objects to be aligned in ReadObject, and back
references
to be aligned to skip padding.
The motivation to change the undefined next sentinel in WeakCell is this:
When the deserializer aligns an object, it requires filler maps to already
exist to create filler objects as padding. However, deserializing the
filler map leads to deserializing NaN, which as heap number is aligned:
filler map > meta map > weak cell cache > undefined > NaN
If we use the-hole instead of undefined as sentinel, it works.
[email protected],[email protected]
BUG=v8:4178
LOG=N
Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6
Cr-Commit-Position: refs/heads/master@{#29044}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4178
Review URL: https://codereview.chromium.org/1173253006
Cr-Commit-Position: refs/heads/master@{#29045}
[modify]
http://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772/src/code-stubs-hydrogen.cc
[modify]
http://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772/src/heap/heap.cc
[modify]
http://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772/src/heap/mark-compact.cc
[modify]
http://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772/src/heap/objects-visiting-inl.h
[modify]
http://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772/src/snapshot/serialize.cc
[modify]
http://crrev.com/33ae0e6762011e80172b84054a0a90e3b0822772/src/snapshot/serialize.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
