Comment #5 on issue 4178 by [email protected]: support
double-unaligned (and maybe simd128-unaligned) for snapshot
https://code.google.com/p/v8/issues/detail?id=4178#c5
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/63f4c751625e6d9948ef2276ebacdd7fc7d916a6
commit 63f4c751625e6d9948ef2276ebacdd7fc7d916a6
Author: yangguo <[email protected]>
Date: Tue Jun 16 11:04:13 2015
Serializer: support all alignment kinds.
We use an alignment prefix for unusual alignment kinds (not kWordAligned).
This will cause new objects to be aligned in ReadObject, and back references
to be aligned to skip padding.
The motivation to change the undefined next sentinel in WeakCell is this:
When the deserializer aligns an object, it requires filler maps to already
exist to create filler objects as padding. However, deserializing the
filler map leads to deserializing NaN, which as heap number is aligned:
filler map > meta map > weak cell cache > undefined > NaN
If we use the-hole instead of undefined as sentinel, it works.
[email protected],[email protected]
BUG=v8:4178
LOG=N
Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6
Cr-Commit-Position: refs/heads/master@{#29044}
Review URL: https://codereview.chromium.org/1179873003
Cr-Commit-Position: refs/heads/master@{#29047}
[modify]
http://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6/src/code-stubs-hydrogen.cc
[modify]
http://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6/src/heap/heap.cc
[modify]
http://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6/src/heap/mark-compact.cc
[modify]
http://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6/src/heap/objects-visiting-inl.h
[modify]
http://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6/src/snapshot/serialize.cc
[modify]
http://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6/src/snapshot/serialize.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
