Comment #6 on issue 4085 by [email protected]: TypedArray proto chain
is wrong
https://code.google.com/p/v8/issues/detail?id=4085#c6
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/b4d3e1ceba6553b1a10326965f28f46a6653489e
commit b4d3e1ceba6553b1a10326965f28f46a6653489e
Author: machenbach <[email protected]>
Date: Wed Jun 17 09:05:34 2015
Revert of Add %TypedArray% to proto chain (patchset #6 id:100001 of
https://codereview.chromium.org/1186733002/)
Reason for revert:
[Sheriff] Changes layout tests:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/429
See e.g.:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/429/layout-test-results/inspector/console/console-big-array-pretty-diff.html
Please upload a blink side needsmanualrebaseline change first for these
tests if the change is intended. Please also add a blink trybot on a reland
of this CL.
Original issue's description:
Add %TypedArray% to proto chain
According to the ES6 spec, the main methods and getters shouldn't
be properties of the individual TypedArray objects and prototypes
but instead on %TypedArray% and %TypedArray%.prototype. This
difference is observable through introspection. This patch moves
some methods and getters to the proper place, with the exception
of %TypedArray%.prototype.subarray and harmony methods. These will
be moved in follow-on patches.
BUG=v8:4085
LOG=Y
R=adamk
Committed: https://crrev.com/a10590158260737b256fac3254b4939f48f90095
Cr-Commit-Position: refs/heads/master@{#29057}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4085
Review URL: https://codereview.chromium.org/1192433003
Cr-Commit-Position: refs/heads/master@{#29070}
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/src/harmony-typedarray.js
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/src/runtime/runtime-function.cc
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/src/runtime/runtime-object.cc
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/src/typedarray.js
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/test/mjsunit/es6/built-in-accessor-names.js
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/test/mjsunit/get-prototype-of.js
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/test/mjsunit/harmony/sharedarraybuffer.js
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/test/mjsunit/harmony/typedarrays-of.js
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/test/mjsunit/harmony/typedarrays.js
[modify]
http://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e/test/mjsunit/regress/regress-typedarray-length.js
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
