LGTM with comments.
https://codereview.chromium.org/1157943003/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1157943003/diff/60001/src/heap/mark-compact.cc#newcode2485
src/heap/mark-compact.cc:2485:
DCHECK(TransitionArray::IsFullTransitionArray(transitions));
This DCHECK is unneeded, as it duplicates line 2475.
https://codereview.chromium.org/1157943003/diff/60001/src/transitions-inl.h
File src/transitions-inl.h (right):
https://codereview.chromium.org/1157943003/diff/60001/src/transitions-inl.h#newcode81
src/transitions-inl.h:81: DCHECK(!cell->cleared());
This relies on ClearMapTransitions() making sure that all transition
arrays are always properly compacted and right-trimmed, so there are no
cleared cells in the array during normal execution. Is that intentional?
Seems fine, but I'd like a comment here stating this explicitly.
https://codereview.chromium.org/1157943003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
