One post-commit comment, based on a /analyze warning. Just an FYI.
https://codereview.chromium.org/1157943003/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1157943003/diff/80001/src/heap/mark-compact.cc#newcode2490
src/heap/mark-compact.cc:2490: WeakCell* target_cell =
t->GetTargetCell(i);
This variable declaration shadows the target_cell variable of the same
type in the outer scope. There doesn't appear to be a bug here, but this
can cause confusion. Consider either reusing the outer variable or using
a different name.
https://codereview.chromium.org/1157943003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
